[ADT] Adjust parameter names for DenseMap constructors (NFC) #158501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have:
explicit SmallDenseMap(unsigned NumElementsToReservre = 0) {
init(NumElementsToReservre);
}
This patch adjusts the variable name in the DenseMap counterpart for
consistency and clarity.
|
@llvm/pr-subscribers-llvm-adt Author: Kazu Hirata (kazutakahirata) ChangesWe now have: explicit SmallDenseMap(unsigned NumElementsToReservre = 0) { This patch adjusts the variable name in the DenseMap counterpart for Full diff: https://github.com/llvm/llvm-project/pull/158501.diff 1 Files Affected:
diff --git a/llvm/include/llvm/ADT/DenseMap.h b/llvm/include/llvm/ADT/DenseMap.h
index b478ce21d79e6..3226eeaea7d0b 100644
--- a/llvm/include/llvm/ADT/DenseMap.h
+++ b/llvm/include/llvm/ADT/DenseMap.h
@@ -710,9 +710,11 @@ class DenseMap : public DenseMapBase<DenseMap<KeyT, ValueT, KeyInfoT, BucketT>,
unsigned NumBuckets;
public:
- /// Create a DenseMap with an optional \p InitialReserve that guarantee that
- /// this number of elements can be inserted in the map without grow()
- explicit DenseMap(unsigned InitialReserve = 0) { init(InitialReserve); }
+ /// Create a DenseMap with an optional \p NumElementsToReservre to guarantee
+ /// that this number of elements can be inserted in the map without grow().
+ explicit DenseMap(unsigned NumElementsToReservre = 0) {
+ init(NumElementsToReservre);
+ }
DenseMap(const DenseMap &other) : BaseT() {
init(0);
|
kazutakahirata
changed the title
kazutakahirata
changed the title
kuhar
approved these changes
Sep 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that both DenseMap and SmallDenseMap have:
explicit DenseMap(unsigned NumElementsToReserve = 0) {
init(NumElementsToReserve);
}
for consistency and clarity (modulo the class name, of course).